Filter connections list on source or destination item pages #21027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leans up some excess API calls.
octavia-squidington-iv
added
area/platform
…ation-list-item-pages
…ation-list-item-pages
…ation-list-item-pages
…nation button has the right data available.
…ation-list-item-pages
…ation-list-item-pages
…connections-on-source-and-destination-list-item-pages
…ation-list-item-pages
…ation-list-item-pages
teallarson
approved these changes
Jan 18, 2023
| ); | ||
|
|
||
| const sourceDropdownOptions: DropdownMenuOptionType[] = useMemo( | ||
| // We load all sources so the add source button has a pre-filled list of options. |
There was a problem hiding this comment.
Suggested change
| // We load all sources so the add source button has a pre-filled list of options. | |
| // We load all configured sources so the add source button has a pre-filled list of options. |
| @@ -52,23 +47,20 @@ const SourceItemPage: React.FC = () => { | |||
| { label: source.name }, | |||
| ]; | |||
|
|
|||
| const connectionsWithSource = connections.filter(({ source: { sourceId } }) => sourceId === source.sourceId); | |||
|
|
|||
| // We load all destinations so the add destination button has a pre-filled list of options. | |||
There was a problem hiding this comment.
Suggested change
| // We load all destinations so the add destination button has a pre-filled list of options. | |
| // We load all configured destinations so the add destination button has a pre-filled list of options. |
krishnaglick
deleted the
kc/filter-connections-on-source-and-destination-list-item-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21025
What
Adds filtering to the source and destination item pages, as well as cleans up some excess API calls.
How
The source or destination ID is now passed into the connections list call on the source and destination item pages.